Update slug style to use _ instead of - #1426

est31 · 2022-08-12T09:22:06Z

Due to changes by rust-lang/rust#100377

est31 · 2022-08-12T09:22:19Z

cc @davidtwco

davidtwco

LGTM, a couple of fixes, almost all correcting my previous mistakes.

src/diagnostics/diagnostic-structs.md

src/diagnostics/translation.md

src/diagnostics/diagnostic-structs.md

davidtwco · 2022-08-16T08:30:05Z

rust-lang/rust#100377 has landed now

tshepang · 2022-08-16T08:49:01Z

@davidtwco you should be able to merge this if you are happy

davidtwco · 2022-08-16T08:49:43Z

@davidtwco you should be able to merge this if you are happy

I'm still waiting on a comment to be resolved.

davidtwco

Thanks for sticking with this, there's a few more pre-existing out-of-date parts that I'd appreciate if you updated, then we can merge this :)

davidtwco · 2022-08-17T08:27:47Z

src/diagnostics/diagnostic-structs.md

        diag.set_span(self.span);
        diag.span_label(
            self.span,
-            rustc_errors::DiagnosticMessage::fluent_attr("typeck-field-already-declared", "label")
+            rustc_errors::DiagnosticMessage::FluentAttr(


We use the typed identifiers here too...

davidtwco · 2022-08-17T08:27:54Z

src/diagnostics/diagnostic-structs.md

        );
        diag.span_label(
            self.prev_span,
-            rustc_errors::DiagnosticMessage::fluent_attr("typeck-field-already-declared", "previous-decl-label")
+            rustc_errors::DiagnosticMessage::FluentAttr(


..and here..

davidtwco · 2022-08-17T08:28:00Z

src/diagnostics/diagnostic-structs.md

@@ -304,11 +305,11 @@ impl<'tcx> AddToDiagnostic for ExpectedReturnTypeLabel<'tcx> {
        use rustc_errors::{Applicability, IntoDiagnosticArg};
        match self {
            ExpectedReturnTypeLabel::Unit { span } => {
-                diag.span_label(span, DiagnosticMessage::fluent("typeck-expected-default-return-type"))
+                diag.span_label(span, DiagnosticMessage::fluent("typeck_expected_default_return_type"))


..and here..

davidtwco · 2022-08-17T08:28:04Z

src/diagnostics/diagnostic-structs.md

            }
            ExpectedReturnTypeLabel::Other { span, expected } => {
                diag.set_arg("expected", expected);
-                diag.span_label(span, DiagnosticMessage::fluent("typeck-expected-return-type"))
+                diag.span_label(span, DiagnosticMessage::fluent("typeck_expected_return_type"))


..and here..

Due to changes by rust-lang/rust#100377

Update books ## nomicon 1 commits in 8e6aa3448515a0654e347b5e2510f1d4bc4d5a64..d880e6ac2acf133dce640da24b9fb692844f02d4 2022-08-15 15:36:13 -0700 to 2022-08-24 12:42:34 -0700 - Update lifetimes.md (rust-lang/nomicon#372) ## reference 2 commits in e647eb102890e8927f488bea12672b079eff8d9d..f62e93c28323ed9637d0a205a0c256498674a509 2022-08-16 11:35:27 -0700 to 2022-08-28 10:01:28 -0700 - Update examples of what implements `Termination` (rust-lang/reference#1256) - allow to quickly edit a page directly on github (rust-lang/reference#1254) ## book 7 commits in 42ca0ef484fcc8437a0682cee23abe4b7c407d52..0a5421ceb238357b3634fb75234eba4d1dad643c 2022-08-12 21:52:02 -0400 to 2022-08-28 19:51:04 -0400 - Add a missing line generated by 'cargo new' - Clarify ThreadPool-Worker analogy wording - Fixed incorrect mutex lock usage - Merge remote-tracking branch 'origin/pr/3314' - Put interactive book notice in a blockquote box to draw attention to it - Remove the word 'new' because someday it won't be new anymore - Merge remote-tracking branch 'origin/pr/3304' ## rustc-dev-guide 27 commits in d3daa1f..04892c1 2022-08-13 10:00:38 +0900 to 2022-08-29 20:07:51 +0200 - Fix the link to `Parser` struct - Remove a dangling link on "The `#[test]` attribute" - Update the stabilization guide to refer to the new placeholder system - Refine the lintstore section (rust-lang/rustc-dev-guide#1429) - typo - Updates text to refer to LLVM documentation. - Updates LLVM prereqs since upgrade to C++17. - we got 3 (rust-lang/rustc-dev-guide#1447) - A few corrections - Update some statements - correct typo in parallel-rustc.md - Correct some statements in parallel-rustc.md - update parallel-rustc.md - address review comment - make date-check more easy to use - update thir output (rust-lang/rustc-dev-guide#1445) - do not offer option to run code (rust-lang/rustc-dev-guide#1442) - fix quick-edit link (rust-lang/rustc-dev-guide#1441) - Document changes introduced by kind-less SessionDiagnostics - diagnostics: fix outdated use of string slugs (rust-lang/rustc-dev-guide#1436) - Add missing lifetime (rust-lang/rustc-dev-guide#1439) - more syntax fixes - fix incorrect #[note] syntax - Update slug style to use _ instead of - (rust-lang/rustc-dev-guide#1426) - remove incorrect info (rust-lang/rustc-dev-guide#1435) - fix lifetime name (rust-lang/rustc-dev-guide#1431) - Update the date reference around Git submodule bug (rust-lang/rustc-dev-guide#1430)

Update books ## nomicon 1 commits in 8e6aa3448515a0654e347b5e2510f1d4bc4d5a64..d880e6ac2acf133dce640da24b9fb692844f02d4 2022-08-15 15:36:13 -0700 to 2022-08-24 12:42:34 -0700 - Update lifetimes.md (rust-lang/nomicon#372) ## reference 2 commits in e647eb102890e8927f488bea12672b079eff8d9d..f62e93c28323ed9637d0a205a0c256498674a509 2022-08-16 11:35:27 -0700 to 2022-08-28 10:01:28 -0700 - Update examples of what implements `Termination` (rust-lang/reference#1256) - allow to quickly edit a page directly on github (rust-lang/reference#1254) ## book 7 commits in 42ca0ef484fcc8437a0682cee23abe4b7c407d52..0a5421ceb238357b3634fb75234eba4d1dad643c 2022-08-12 21:52:02 -0400 to 2022-08-28 19:51:04 -0400 - Add a missing line generated by 'cargo new' - Clarify ThreadPool-Worker analogy wording - Fixed incorrect mutex lock usage - Merge remote-tracking branch 'origin/pr/3314' - Put interactive book notice in a blockquote box to draw attention to it - Remove the word 'new' because someday it won't be new anymore - Merge remote-tracking branch 'origin/pr/3304' ## rustc-dev-guide 27 commits in d3daa1f28e169087becbc5e2b49ac91ca0405a44..04892c1a6fc145602ac7367945fda9d4ee83c9fb 2022-08-13 10:00:38 +0900 to 2022-08-29 20:07:51 +0200 - Fix the link to `Parser` struct - Remove a dangling link on "The `#[test]` attribute" - Update the stabilization guide to refer to the new placeholder system - Refine the lintstore section (rust-lang/rustc-dev-guide#1429) - typo - Updates text to refer to LLVM documentation. - Updates LLVM prereqs since upgrade to C++17. - we got 3 (rust-lang/rustc-dev-guide#1447) - A few corrections - Update some statements - correct typo in parallel-rustc.md - Correct some statements in parallel-rustc.md - update parallel-rustc.md - address review comment - make date-check more easy to use - update thir output (rust-lang/rustc-dev-guide#1445) - do not offer option to run code (rust-lang/rustc-dev-guide#1442) - fix quick-edit link (rust-lang/rustc-dev-guide#1441) - Document changes introduced by kind-less SessionDiagnostics - diagnostics: fix outdated use of string slugs (rust-lang/rustc-dev-guide#1436) - Add missing lifetime (rust-lang/rustc-dev-guide#1439) - more syntax fixes - fix incorrect #[note] syntax - Update slug style to use _ instead of - (rust-lang/rustc-dev-guide#1426) - remove incorrect info (rust-lang/rustc-dev-guide#1435) - fix lifetime name (rust-lang/rustc-dev-guide#1431) - Update the date reference around Git submodule bug (rust-lang/rustc-dev-guide#1430)

davidtwco reviewed Aug 12, 2022

View reviewed changes

src/diagnostics/diagnostic-structs.md Outdated Show resolved Hide resolved

src/diagnostics/diagnostic-structs.md Outdated Show resolved Hide resolved

src/diagnostics/translation.md Show resolved Hide resolved

est31 force-pushed the fluent_underscore branch 2 times, most recently from e6ed8a9 to 4165dfb Compare August 12, 2022 10:27

JohnTitor added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 13, 2022

davidtwco reviewed Aug 15, 2022

View reviewed changes

src/diagnostics/diagnostic-structs.md Outdated Show resolved Hide resolved

est31 force-pushed the fluent_underscore branch from 4165dfb to 6e0663e Compare August 16, 2022 06:04

est31 force-pushed the fluent_underscore branch from 6e0663e to cc5bac8 Compare August 16, 2022 18:35

davidtwco requested changes Aug 17, 2022

View reviewed changes

JohnTitor added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Aug 17, 2022

Update slug style to use _ instead of -

f6c3767

Due to changes by rust-lang/rust#100377

est31 force-pushed the fluent_underscore branch from cc5bac8 to f6c3767 Compare August 17, 2022 18:11

davidtwco approved these changes Aug 17, 2022

View reviewed changes

davidtwco merged commit 2512667 into rust-lang:master Aug 17, 2022

ehuss mentioned this pull request Aug 30, 2022

Update books rust-lang/rust#101219

Merged

est31 mentioned this pull request Oct 21, 2022

Update diagnostics migration blog post to use new flat slugs rust-lang/blog.rust-lang.org#1040

Merged

Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 3, 2025

Update slug style to use _ instead of - (rust-lang#1426)

7c8bf03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update slug style to use _ instead of - #1426

Update slug style to use _ instead of - #1426

Uh oh!

est31 commented Aug 12, 2022

Uh oh!

est31 commented Aug 12, 2022

Uh oh!

davidtwco left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidtwco commented Aug 16, 2022

Uh oh!

tshepang commented Aug 16, 2022

Uh oh!

davidtwco commented Aug 16, 2022

Uh oh!

davidtwco left a comment

Uh oh!

davidtwco Aug 17, 2022

Uh oh!

davidtwco Aug 17, 2022

Uh oh!

davidtwco Aug 17, 2022

Uh oh!

davidtwco Aug 17, 2022

Uh oh!

Uh oh!

Update slug style to use _ instead of - #1426

Update slug style to use _ instead of - #1426

Uh oh!

Conversation

est31 commented Aug 12, 2022

Uh oh!

est31 commented Aug 12, 2022

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidtwco commented Aug 16, 2022

Uh oh!

tshepang commented Aug 16, 2022

Uh oh!

davidtwco commented Aug 16, 2022

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

davidtwco Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

davidtwco Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

davidtwco Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

davidtwco Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!