Skip to content

Conversation

ali90h
Copy link
Contributor

@ali90h ali90h commented Aug 28, 2025

Updated explicit date annotations to 2025-08

Addresses #2528.

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 28, 2025
@ali90h
Copy link
Contributor Author

ali90h commented Aug 28, 2025

r? rustc-dev-guide

@jyn514
Copy link
Member

jyn514 commented Aug 28, 2025

you don't need reviews for small stuff like this.

oh i see you're not in the org—@rust-lang/wg-rustc-dev-guide any objection to adding ali to the team so they can get merge rights?

@jyn514 jyn514 merged commit 384f5a1 into rust-lang:master Aug 28, 2025
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 28, 2025
@ali90h
Copy link
Contributor Author

ali90h commented Aug 28, 2025

Thanks @jyn514 I am very happy about this.

@tshepang
Copy link
Member

@jyn514 I think we would want to see some sustained contributions before we move there... often it happens people contribute for a bit then leave, otherwise we will have lots of churn in team membership (where some members do not even respond to questions of if they want to continue being in the team). To be clear, this is not a blocking concern (I would not want to gatekeep), so maybe others can decide that the churn is not something to be concerned about. Also, we don't have a charter I know of (I should actually just ask/search how others were accepted into the team), and we probably must create one, to avoid the ad-hoc.

@ali90h
Copy link
Contributor Author

ali90h commented Aug 29, 2025

Thanks for the guidance and continued support. I’ll keep contributing and hope to live up to your expectations.

@ali90h ali90h deleted the date-sweep-2025-08-infra branch August 29, 2025 15:15
@ali90h ali90h mentioned this pull request Aug 29, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants