Feat; queuing try commits #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamesbarford
force-pushed
the
feat/queuing-try-commits
branch
from
8da2e96 to
a9325dc
Compare
Kobzol
reviewed
Jul 9, 2025
| backends, | ||
| "", | ||
| ); | ||
| conn.insert_benchmark_request(&try_request).await; |
There was a problem hiding this comment.
I wonder if we should return an error here, so that we can e.g. tell to the user that a request already exists, so they can't queue another one, otherwise it will be essentially a silent failure. But we can do that in a future PR.
There was a problem hiding this comment.
Yeah I reckon so, happy to do it in a follow up PR
Kobzol
reviewed
Jul 9, 2025
Jamesbarford
force-pushed
the
feat/queuing-try-commits
branch
from
25d0969 to
cc65504
Compare
Kobzol
reviewed
Jul 9, 2025
Kobzol
reviewed
Jul 9, 2025
Kobzol
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUN_CRONenvironment variable to a function