Check latest commit SHA in the collector #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that jobs from the same request are batched together.
Kobzol
force-pushed
the
collector-sha-check
branch
from
0adf914 to
a13a464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end I decided to just query GitHub directly, it's the easiest thing to do, and we should only do it only ~once per hour, so should be fine. It was much easier than adding a singleton database table and threading the git information from the website.
It permits some slight desync of the SHA in the collector and the website, but that also happened before and we ~never had issues with it.
I made the periodic check optional to avoid annoying restarts when running the collector locally.