Skip to content

Avoid creating locals for unrechable terminators. #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Avoid creating locals for unrechable terminators. #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,20 @@ impl<'a, 'gcc, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'gcc, 'tcx> {
self.block.add_eval(self.location, self.context.new_call(self.location, func, &[]));
let return_type = self.block.get_function().get_return_type();
let void_type = self.context.new_type::<()>();
#[cfg(feature = "master")]
let is_float = return_type.is_floating_point();
#[cfg(not(feature = "master"))]
let is_float = false;
if return_type == void_type {
self.block.end_with_void_return(self.location)
}
// For ints, floats and pointers, we can avoid creating the temporary local, and just return 0 / null.
// This should have no effect on runtime: GCC already knows that everything after __builtin_unreachable
// is unreachable.
else if self.is_native_int_type(return_type) || is_float {
self.block.end_with_return(self.location, self.context.new_rvalue_zero(return_type))
} else if return_type.get_pointee().is_some() {
self.block.end_with_return(self.location, self.context.new_null(return_type))
} else {
let return_value =
self.current_func().new_local(self.location, return_type, "unreachableReturn");
Expand Down