Skip to content

Conversation

x0rw
Copy link
Contributor

@x0rw x0rw commented Jul 16, 2025

  • add GitHub Action to fail the build if not formatted according to ruff
  • tweak ruff settings as necessary
  • add to README.md about how to configure a contributor's ruff settings and/or (ideally) include those in the repo so that it "just works" for contributors

Resolves #146

Copy link

netlify bot commented Jul 16, 2025

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 134dbcf
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/68ab85fd70fe9100086ec121
😎 Deploy Preview https://deploy-preview-150--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur
Copy link
Collaborator

Hi @x0rw -- is this still a draft or ready for review? I saw a couple of unticked boxes

@x0rw
Copy link
Contributor Author

x0rw commented Aug 7, 2025

Hi @PLeVasseur,
This looks fine to me now, also there is no need for README.md explaination, as pyproject.toml is self explanatory and well commented.
Also every lint ignored in lint.ignore can be considered a TODO for us, but they require more manual testing because we don't have unit tests,

let me know what you think.

Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @x0rw -- thanks for the updates! I left a couple of comments if you could take a look

@felix91gr felix91gr added enhancement New feature or request ci/cd Related to CI/CD labels Aug 11, 2025
@x0rw x0rw force-pushed the python-feature/ruff branch from dab079c to 134dbcf Compare August 24, 2025 21:36
@x0rw x0rw requested a review from PLeVasseur August 24, 2025 21:39
@plaindocs plaindocs added the contributor experience Related to making contributions easier label Aug 27, 2025
Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x0rw -- thanks for the contribution! ☺️

@PLeVasseur PLeVasseur added this pull request to the merge queue Aug 31, 2025
Merged via the queue into rustfoundation:main with commit bad4e14 Aug 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Related to CI/CD contributor experience Related to making contributions easier enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Use ruff Python formatter
4 participants