Check for string-type parameter VALUE #640
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
=========================================
Coverage 98.78% 98.78%
- Complexity 1875 1877 +2
=========================================
Files 71 71
Lines 5270 5273 +3
=========================================
+ Hits 5206 5209 +3
Misses 64 64 ☔ View full report in Codecov by Sentry. |
|
CI passes, so existing test cases are still OK. Need a response to #636 (comment) to be able to add a useful extra unit test case. |
phil-davis
force-pushed
the
martij-createProperty-value
branch
from
79e9b3b to
68d7d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #636