Skip to content

Improve _element_constructor_ of image set #40250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Jun 13, 2025

Allow the example shown to work.

        sage: R.<x> = QQ[]
        sage: S.<y> = QQ[]
        sage: R.hom([y^2]).inverse_image(y^4)
        x^2
        sage: y^4 in R.hom([y^2]).image()
        True

Also mention that it is not recommended to pass inverse=... to ImageSubobject constructor — there should be no need for this, it is better (and more discoverable) to define the .inverse_image method on the map.

I could have deprecated it, but decide to leave it there just in case. The only place within the doctest that it is used is in the file itself.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 force-pushed the image-set-constructor branch from 4e414d4 to a39b533 Compare June 13, 2025 10:30
Copy link

github-actions bot commented Jun 13, 2025

Documentation preview for this PR (built with commit d434deb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 marked this pull request as ready for review June 13, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant