Skip to content

Update msolve 0.8.0 #40260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

vbraun
Copy link
Member

@vbraun vbraun commented Jun 15, 2025

Mainly to get us out of the sticky situation with the modified 0.7.5 tarball, for which we have two conflicting binaries breaking the gh release workflow: https://github.com/sagemath/sage/actions/runs/15656638164/job/44108544612

@dimpase
Copy link
Member

dimpase commented Jun 15, 2025

I see various patches here - does this PR depend on some other PRs, or this is all for msolve?

Copy link

github-actions bot commented Jun 16, 2025

Documentation preview for this PR (built with commit 2712e48; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Mainly to get us out of the sticky modified tarball version with 0.7.5
@vbraun vbraun force-pushed the update-msolve-0.8.0 branch from 5fe1aca to 3b75886 Compare June 16, 2025 07:39
@vbraun
Copy link
Member Author

vbraun commented Jun 16, 2025

Oops wrong base branch, fixed

@dimpase
Copy link
Member

dimpase commented Jun 16, 2025

ok

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 17, 2025
sagemathgh-40260: Update msolve 0.8.0
    
Mainly to get us out of the sticky situation with the modified 0.7.5
tarball, for which we have two conflicting binaries breaking the gh
release workflow:  https://github.com/sagemath/sage/actions/runs/1565663
8164/job/44108544612
    
URL: sagemath#40260
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
@jeriedel24
Copy link

IMHO this PR is incomplete. The update from msolve 0.6.0 to 0.7.5 or to 0.8.0 breaks the feature check in src/sage/features/msolve.py.
In the method is_functional we call msolve -h, and we check if the first 46 characters of the output are the string b'\nmsolve library for polynomial system solving\n' (lines 57 to 63).
However in msolve 0.8.0 that line of output does not end with solving\n but it ends with solving, version 0.8.0\n.
Hence I suggest that src/sage/features/msolve.py be adapted to that.

format has changed
@dimpase
Copy link
Member

dimpase commented Jun 17, 2025

@vbraun - see vbraun#1
for the fix

@jeriedel24
Copy link

Thank you for taking care of that.

remove CR from msolve pattern
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 18, 2025
sagemathgh-40260: Update msolve 0.8.0
    
Mainly to get us out of the sticky situation with the modified 0.7.5
tarball, for which we have two conflicting binaries breaking the gh
release workflow:  https://github.com/sagemath/sage/actions/runs/1565663
8164/job/44108544612
    
URL: sagemath#40260
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants