Skip to content

Remove Maxima pexpect interface #40265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Remove Maxima pexpect interface #40265

wants to merge 5 commits into from
+231 −1,734

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Jun 17, 2025 •
edited
Loading

Fixes #17753 and fixes #30071

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 47e874e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor Author

Tests are green, so this is now ready for review.

@tobiasdiez tobiasdiez marked this pull request as ready for review June 19, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbruin nbruin Awaiting requested review from nbruin

@vincentmacri vincentmacri Awaiting requested review from vincentmacri

@dimpase dimpase Awaiting requested review from dimpase

Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

speed up Maxima computations by using more of maxima_calculus.eval() move pexpect-maxima code to maxima_lib
1 participant
@tobiasdiez