fix: Do not unnecessarily require Debug on fields for interned structs
#951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
Veykril
force-pushed
the
veykril/push-uwnvzqlolvsr
branch
from
5f8affd to
bed8cb1
Compare
CodSpeed Performance ReportMerging #951 will not alter performanceComparing Summary
|
ibraheemdev
reviewed
Aug 5, 2025
Comment on lines
+263
to
+264
| iftt ($($db_lt_arg)?) { | ||
| impl $Struct<'_> { |
There was a problem hiding this comment.
Shouldn't impl<$($db_lt_arg)?> $Struct<$($db_lt_arg)?> work? Why does this need a separate impl block at all?
There was a problem hiding this comment.
That causes issues with the higher ranked where clauses due to lifetime shadowing unfortunately
ibraheemdev
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.