grid-custom column extending issue #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe I'm missing something, but I checked this out, if we extend our FlagColumn class from CDataColumn instead of CGridColumn we don't have to copy renderHeaderCellContent method and renderFilterCellContent (to make filter working) Also, it seems to be a bug in a book https://www.dropbox.com/s/csu2zugwi15e1un/yii-bug.png
min change
|
Thanks for the report. Will check it in details this week. |
|
Extending CDataColumn instead of CGridColumn is indeed a better way in most cases when you want sorting and filtering. Also if CLinkColumn would extend CDataColumn it would be much more usable. We had discussion about that earlier in yii issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing something, but I checked this out, if we extend our FlagColumn class from CDataColumn instead of CGridColumn we don't have to copy renderHeaderCellContent method and renderFilterCellContent (to make filter working)
Also, it seems to be a bug in a book https://www.dropbox.com/s/csu2zugwi15e1un/yii-bug.png