try to reconect on some exceptions #1594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the WebSocket reconnection logic to handle additional exceptions as recoverable instead of fatal, allowing the connection to automatically retry rather than completely failing.
- Adds
ConnectionClosedOKexception handling for graceful connection closures - Moves
BinanceWebsocketUnableToConnectfrom fatal to recoverable exception category
| @@ -15,9 +15,9 @@ | |||
| pass | |||
|
|
|||
| try: | |||
| from websockets.exceptions import ConnectionClosedError # type: ignore | |||
| from websockets.exceptions import ConnectionClosedError, ConnectionClosedOK # type: ignore | |||
There was a problem hiding this comment.
The PR title contains a spelling error: 'reconect' should be 'reconnect'.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give it a chance to reconnect on some non-fatal exceptions.