Skip to content

Docker tagging #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Docker tagging #53

wants to merge 3 commits into from

Conversation

timakro
Copy link
Contributor

@timakro timakro commented Jun 23, 2025

Main intention same as #52:

Currently, the latest tag is always added to the images from the repositories default branch.
With this change, the latest tag will only be updated when pushing a git tag matching the semantic versioning scheme.

This PR implements it differently, instead of using type=match it uses flavor: latest=auto. This aligns with the examples in the docker/metadata-action readme and seems to be the intended way of controlling the "latest" tag

Details

Updated the tagging rules to be roughly equivalent to the semver example from the docker/metadata-action readme here.

Also disabled <major> tagging when major is 0 as suggested in docker/metadata-action readme.

Also removed suffix=${{ inputs.image-tag-suffix }}pr- as this was bogus anyways and most likely not needed as global prefix and suffix should apply always.

Also removed a step that I believe was unused (see commit message of first commit)

timakro added 2 commits June 23, 2025 10:26
If `env.ghcr != 'true'` there is no docker push so calculating tags is unnecessary I think
@timakro timakro requested a review from torbrenner June 23, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant