-
Notifications
You must be signed in to change notification settings - Fork 14
Nick/create problem #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ntjohnson1
wants to merge
20
commits into
sandialabs:main
Choose a base branch
from
ntjohnson1:nick/create_problem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nick/create problem #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to land #432 first since that resolves all of our doc warnings. I didn't fully merge it here so if that merges first I probably need to review this to make sure I didn't break any new stuff. Alternatively if we want to land this first I can revert the few unrelated commits (they made local iteration cleaner to avoid whatever mac precision thing I'm hitting).
This resolves #312. I added tests but hard to say if things are totally correct. For the sparse generation example in the tutorial I never fully groked that before and didn't dig into it now but the results all seem to look reasonable. There will probably be follow on after this to actual move usages over to this implementation, related to #363. This ended up being a large task than expected so punting on that for now.
Style things:
📚 Documentation preview 📚: https://pyttb--442.org.readthedocs.build/en/442/