fix image api missing filename bug #1017
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
- Coverage 85.77% 85.43% -0.35%
==========================================
Files 43 43
Lines 2291 2313 +22
==========================================
+ Hits 1965 1976 +11
- Misses 304 315 +11
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Axb12
commented
Jun 10, 2025
| return file{rdr, filename, contentType} | ||
| } | ||
|
|
||
| type file struct { |
There was a problem hiding this comment.
I'm not sure if the file struct should be put here
Axb12
commented
Jun 10, 2025
| filename = f.Name() | ||
| } | ||
| } | ||
| var contentType string |
There was a problem hiding this comment.
I'm not sure if the default Content-Type is set to application/octet-stream here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug that the filename was missing due to the last PR.(#994)
I've added a file struct to override what was going on before the last PR.(#994)
I'm so sorry because of my negligence that caused this issue.
Here are two related issues I've seen:(#1012), (#1010)