Skip to content

chore: add the overrides from scala-js/scala-js #23670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Aug 6, 2025

Add the overridden files by Scala.js
We decided not to include the full history here as the repo had a history of changing the folder layout and it can be tricky to manage.
The files were extracted as is in scala-js/scala-js@d6d6a37 https://github.com/scala-js/scala-js/tree/v1.19.0

Note that these files are not included yet in the build and are ignored for the moment.

Related to: scala-js/scala-js#5217

@hamzaremmal hamzaremmal requested a review from sjrd August 6, 2025 09:28
@hamzaremmal hamzaremmal requested a review from a team as a code owner August 6, 2025 09:28
@hamzaremmal hamzaremmal enabled auto-merge August 6, 2025 09:29
@sjrd
Copy link
Member

sjrd commented Aug 6, 2025

The files were extracted as is in scala-js/scala-js@d6d6a37

For consistency we should take them exactly as in v1.19.0. The rest of the Scala.js-specific stuff, notably the Scala.js compiler backend, stay in sync with the declared Scala.js version associated with any given Scala 3 version. Currently that version is v1.19.0.

(This only affects Range.scala.)

@hamzaremmal hamzaremmal merged commit 278b1ed into scala:main Aug 6, 2025
42 checks passed
@hamzaremmal hamzaremmal deleted the scalajs-overrides branch August 6, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants