Skip to content

Extra certificates test #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development/2.12
Choose a base branch
from

Conversation

SylvainSenechal
Copy link
Contributor

@SylvainSenechal SylvainSenechal commented Jul 30, 2025

Issue : ZENKO-4544

@bert-e
Copy link
Contributor

bert-e commented Jul 30, 2025

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2025

Incorrect fix version

The Fix Version/s in issue ZENKO-4544 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.12.6

  • 2.13.0

Please check the Fix Version/s of ZENKO-4544, or the target
branch of this pull request.

AZURE_BACKEND_ENDPOINT: http://devstoreaccount1.blob.azure-mock.zenko.local
AZURE_BACKEND_QUEUE_ENDPOINT: http://devstoreaccount1.queue.azure-mock.zenko.local
AZURE_BACKEND_ENDPOINT: https://devstoreaccount1.blob.azure-mock.zenko.local
AZURE_BACKEND_QUEUE_ENDPOINT: https://devstoreaccount1.queue.azure-mock.zenko.local
AZURE_SECRET_KEY: Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==
AWS_ENDPOINT: http://aws-mock.zenko.local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also use TLS for:

  • AWS mock
  • Mock S3C/metadata (used by ingestion)
  • Mock DMF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylvainSenechal SylvainSenechal force-pushed the feature/ZENKO-4544 branch 3 times, most recently from 4e8fe43 to 8de3b5a Compare August 11, 2025 16:31
@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@SylvainSenechal SylvainSenechal force-pushed the feature/ZENKO-4544 branch 13 times, most recently from c9d273c to 213f333 Compare August 14, 2025 14:21
@scality scality deleted a comment from bert-e Aug 14, 2025
@SylvainSenechal SylvainSenechal marked this pull request as ready for review August 14, 2025 14:30
# certificates issued by our ClusterIssuer. cert-manager keeps secrets in its own namespace,
# so we copy it to the default namespace where zenko-operator will be able to read it.
kubectl get secret root-ca -n cert-manager -o yaml |
sed 's/namespace: cert-manager/namespace: default/' |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be done with kubectl apply -n default -f -

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but actually if we do this we have an error because there is a mismatch between the namespace in the yaml metadata and the specific namespace.
the namespace from the provided object "cert-manager" does not match the namespace "default"

@scality scality deleted a comment from bert-e Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants