CLDSRV-657: KMS tests internal / external migration & arn prefix #5810

BourgoisMickael · 2025-06-02T10:35:22Z

Test is run in 3 steps:

seed before migration
run migration
run kms kms tests on fresh buckets and objects (arnPrefix)

Those tests are based on the kmip test scenario but with more tests around CopyObject, MPU, and asserting on headers as well.

bert-e · 2025-06-02T10:35:25Z

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

BourgoisMickael · 2025-06-11T10:19:58Z

/create_integration_branches

To run outside CI

Run old vault & cloudserver to seed buckets and objects Then replace with latest images to test migration

Test is run in 3 steps: - seed before migration - run migration - run kms kms tests on fresh buckets and objects

dvasilas · 2025-06-16T12:40:00Z

.github/docker/local.sh

+export MPU_TESTING="yes"
+
+export CLOUDSERVER_IMAGE_BEFORE_SSE_MIGRATION=ghcr.io/scality/cloudserver:7.70.66
+export CLOUDSERVER_IMAGE_ORIGINAL=ghcr.io/scality/cloudserver:7.70.70


Are we going to be updating the after migration images to the latest ones?

We can but don't need to for those tests.

BourgoisMickael · 2025-06-16T14:28:35Z

/reset

bert-e · 2025-06-16T14:28:42Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e · 2025-06-16T15:00:20Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-657-kms-tests into
development/7.70
w/8.8/improvement/CLDSRV-657-kms-tests will be merged into development/8.8
w/9.0/improvement/CLDSRV-657-kms-tests will be merged into development/9.0
w/9.1/improvement/CLDSRV-657-kms-tests will be merged into development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-06-16T15:00:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

BourgoisMickael · 2025-06-16T15:00:30Z

/approve

bert-e · 2025-06-16T15:00:46Z

Build failed

The build for commit did not succeed in branch w/8.8/improvement/CLDSRV-657-kms-tests

The following options are set: approve, create_integration_branches

bert-e · 2025-06-16T17:35:29Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-657-kms-tests into
development/7.70
w/8.8/improvement/CLDSRV-657-kms-tests will be merged into development/8.8
w/9.0/improvement/CLDSRV-657-kms-tests will be merged into development/9.0
w/9.1/improvement/CLDSRV-657-kms-tests will be merged into development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve, create_integration_branches

bert-e · 2025-06-16T18:44:52Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-657-kms-tests into
development/7.70
w/8.8/improvement/CLDSRV-657-kms-tests will be merged into development/8.8
w/9.0/improvement/CLDSRV-657-kms-tests will be merged into development/9.0
w/9.1/improvement/CLDSRV-657-kms-tests will be merged into development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve, create_integration_branches

bert-e · 2025-06-16T18:58:35Z

Build failed

The build for commit did not succeed in branch w/9.0/improvement/CLDSRV-657-kms-tests

The following options are set: approve, create_integration_branches

bert-e · 2025-06-16T19:13:05Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/7.70
✔️ development/8.8
✔️ development/9.0
✔️ development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2025-06-16T19:32:06Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/7.70
✔️ development/8.8
✔️ development/9.0
✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4

Please check the status of the associated issue CLDSRV-657.

Goodbye bourgoismickael.

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch from d994d8e to bf0b02b Compare June 2, 2025 10:39

scality deleted a comment from bert-e Jun 2, 2025

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch 17 times, most recently from 4cbfc51 to c6ed795 Compare June 5, 2025 17:47

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch from aa0b646 to 4df4387 Compare June 11, 2025 10:19

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch 4 times, most recently from bcd99d1 to d2c38c1 Compare June 11, 2025 14:45

scality deleted a comment from bert-e Jun 11, 2025

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch from 981d8b5 to 254119c Compare June 11, 2025 15:36

BourgoisMickael changed the base branch from development/7.70 to improvement/CLDSRV-657-pykmip-update June 11, 2025 16:01

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch 2 times, most recently from 11bbac4 to 3a9f102 Compare June 13, 2025 15:11

BourgoisMickael added 4 commits June 16, 2025 02:26

CLDSRV-657: Add pykmip dns in /etc/hosts for tests

1d16169

CLDSRV-657: Local script to run sse kms migration

5f9f672

To run outside CI

CLDSRV-657: Workflow to test sse kms migration

315cefc

Run old vault & cloudserver to seed buckets and objects Then replace with latest images to test migration

CLDSRV-657: Functional tests for sse KMS Migration

7e551c5

Test is run in 3 steps: - seed before migration - run migration - run kms kms tests on fresh buckets and objects

BourgoisMickael force-pushed the improvement/CLDSRV-657-kms-tests branch from 3a9f102 to 7e551c5 Compare June 16, 2025 00:28

scality deleted a comment from bert-e Jun 16, 2025

anurag4DSB approved these changes Jun 16, 2025

View reviewed changes

dvasilas approved these changes Jun 16, 2025

View reviewed changes

CLDSRV-657: Bump version

eff931e

scality deleted a comment from bert-e Jun 16, 2025

bert-e merged commit d736be2 into development/7.70 Jun 16, 2025
17 checks passed

bert-e deleted the improvement/CLDSRV-657-kms-tests branch June 16, 2025 19:32

CLDSRV-657: KMS tests internal / external migration & arn prefix #5810

CLDSRV-657: KMS tests internal / external migration & arn prefix #5810

Uh oh!

Conversation

BourgoisMickael commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Jun 2, 2025

Hello bourgoismickael,

Uh oh!

BourgoisMickael commented Jun 11, 2025

Uh oh!

dvasilas Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael commented Jun 16, 2025

Uh oh!

bert-e commented Jun 16, 2025

Reset complete

Uh oh!

bert-e commented Jun 16, 2025

Integration data created

Uh oh!

bert-e commented Jun 16, 2025

Waiting for approval

Uh oh!

BourgoisMickael commented Jun 16, 2025

Uh oh!

bert-e commented Jun 16, 2025

Build failed

Uh oh!

bert-e commented Jun 16, 2025

Integration data created

Uh oh!

bert-e commented Jun 16, 2025

Integration data created

Uh oh!

bert-e commented Jun 16, 2025

Build failed

Uh oh!

bert-e commented Jun 16, 2025

In the queue

Uh oh!

bert-e commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

BourgoisMickael commented Jun 2, 2025 •

edited

Loading