scxtop: add v0 process view #2434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgesds
reviewed
Jul 21, 2025
|
LGTM |
hodgesds
approved these changes
Jul 21, 2025
hodgesds
reviewed
Jul 21, 2025
| } | ||
|
|
||
| /// Creates a new ProcData from a given tgid. | ||
| pub fn from_tgid(tgid: i32, max_data_size: usize) -> Result<ProcData> { |
There was a problem hiding this comment.
should be easy to generate tests for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an initial process view that is sorted by number of threads. The idea here is to get this out and quickly iterate with new features (more on that below). The process view will be focused on information that would be helpful for scheduler development and debugging as opposed to a general process view like top/btop. Following that idea, the v0 contains the last CPU/LLC/NUMA and DSQ that the process ran on.
This also changes the default view to be more of an overview, pushing the DSQ statistics to the scheduler view (
s).Upcoming Features: