Skip to content

Update shortcodes #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goanpeca
Copy link

@goanpeca goanpeca commented Jun 1, 2025

Hello team!

As part of figure, image and button shortcodes as being updated on scientific-python/scientific-python-hugo-theme#674 I created this PR to prepare the website for moving to the new syntax when a new version is released!

Pinging @agriyakhetarpal

Copy link

netlify bot commented Jun 1, 2025

Deploy Preview for scientific-python-org failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit fd643c7
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-org/deploys/683c6a269f29af00080c7eb0

Copy link

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @goanpeca! I went through the changes and this one is a little different from the rest of them as I noticed that the closing >}} tags are not on a new line – is this because there is something that needs be reworked in our PR upstream w.r.t these TOML tables? Having the closing tags on the same line is also fine to me, so I was just curious about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants