Fix TargetEncoder compatibility with scikit-learn ColumnTransformer #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emonstrate the failure detailed in issue 460. scikit-learn-contrib#460
… that clone the object and validate that the parameters are unchanged. This moves the validation of hierarchy and the generation of an inverted hiearchy to the helper function _generate_inverted_hierarchy. This function is called in __init__ only to keep compatibility with existing tests by throwing an exception from the constructure rather than waiting for the call to fit. We create a variable inverted_hierarchy rather than overwriting self.hierarchy in order for the clone method to pass validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
Proposed Changes
TargetEncoderpassed a non-nullhierarchyobject would throw an exception when used in ascikit-learnColumnTransformer.TargetEncoder__init__method to thefitmethod in order to pass validation tests in thescikit-learnclonemethod.test_hierarchy_with_scikit_learn_column_transformer.