Skip to content

Fix/uepr 258 intermittent scratch vm test failures #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KManolov3
Copy link
Contributor

Resolves

https://scratchfoundation.atlassian.net/browse/UEPR-258

Proposed Changes

Restructure vm initialization in monitors_sb2_to_sb3 test file to prevent intermittent failures due to race condition

Reason for Changes

The failures in above test started happening more often after changes to svg sanitization logic and became a blocker for related development.

@KManolov3 KManolov3 requested a review from a team as a code owner June 20, 2025 08:24
Copy link
Contributor

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiroslavDionisiev MiroslavDionisiev merged commit ff75c31 into UEPR-230 Jun 25, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants