-
Notifications
You must be signed in to change notification settings - Fork 37
Docs: explain prover's design for precompiles #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
trigger the integration test for gkr keccak |
@@ -283,6 +286,8 @@ impl<E: ExtensionField> ZerocheckLayer<E> for Layer<E> { | |||
); | |||
let in_point = in_point.into_iter().map(|c| c.elements).collect_vec(); | |||
|
|||
// TODO: is there any check on eq_left, eq_right, eq for rotation argument? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hero78119 It seems to me that eq_left / eq_right / eq_target
is not checked at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rotation eq will be re-construct when the random point was derived from previous layer
ceno/gkr_iop/src/gkr/layer/cpu/mod.rs
Lines 178 to 198 in ca7b038
.chain(rotation_left.par_iter().map(|rotation_left| { | |
MultilinearExtension::from_evaluations_ext_vec( | |
rotation_left.len(), | |
build_eq_x_r_vec(rotation_left), | |
) | |
})) | |
// for rotation right point | |
.chain(rotation_right.par_iter().map(|rotation_right| { | |
MultilinearExtension::from_evaluations_ext_vec( | |
rotation_right.len(), | |
build_eq_x_r_vec(rotation_right), | |
) | |
})) | |
// for rotation point | |
.chain(rotation_point.par_iter().map(|rotation_point| { | |
MultilinearExtension::from_evaluations_ext_vec( | |
rotation_point.len(), | |
build_eq_x_r_vec(rotation_point), | |
) | |
})) | |
.collect::<Vec<_>>(); |
in summary, eq will transform from A to B format
- format A: each eq will be assign as selector with only 0, 1 during witness generation to serve layer by layer witness inference
- format B: once random point
$$r$$ derive from previous layer, each eq will be constructed viabuild_eq(r)
then proceed sumcheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the array self.out_sel_and_eval_exprs
does not include eq_left / eq_right / eq
.
ceno/gkr_iop/src/gkr/layer/zerocheck_layer.rs
Lines 287 to 297 in ca7b038
izip!(&self.out_sel_and_eval_exprs, &eval_and_dedup_points).for_each( | |
|((sel_type, _), (_, out_point))| { | |
sel_type.evaluate( | |
&mut main_evals, | |
out_point.as_ref().unwrap(), | |
&in_point, | |
num_instances, | |
self.n_witin, | |
); | |
}, | |
); |
No description provided.