fix keccak precompile e2e #1036
Open
+335
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero78119
force-pushed
the
feat/keccak_e2e
branch
from
9b7e271 to
8c312b1
Compare
hero78119
commented
Aug 26, 2025
| @@ -215,9 +215,16 @@ impl<E: ExtensionField, PCS: PolynomialCommitmentScheme<E>> ZKVMVerifier<E, PCS> | |||
| let input_opening_point = if circuit_vk.get_cs().is_opcode_circuit() { | |||
| // getting the number of dummy padding item that we used in this opcode circuit | |||
| let num_lks = circuit_vk.get_cs().num_lks(); | |||
| let num_padded_instance = | |||
There was a problem hiding this comment.
Need to refresh dummy logic when there got rotation
@kunxian-xia @darth-cy recursion-verifier need to fix the respective logic as well
https://github.com/scroll-tech/ceno-recursion-verifier/blob/d7aac029fbd3acb8860af9bec3784e0790c6edc4/src/zkvm_verifier/verifier.rs#L237-L241
With that, keccak precompile should be e2e full pass
hero78119
commented
Aug 26, 2025
| Change::new(state_ptr, state_ptr), | ||
| 0, // Cycle set later in finalize(). | ||
| ), | ||
| WriteOp::new_register_op( |
There was a problem hiding this comment.
This is just to compatible with sp1 binary logic to assure x11 (a2) register are 0.
In Ceno this check seems unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build on top of #1034 & #1035 & #1038
This PR fix keccak precompile e2e error, some previous left over.