Skip to content

Remove unnecessary _stack_start from Rust code #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary _stack_start from Rust code #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ce57e5
Remove unnecessary `_stack_start` from Rust code
matthiasgoergens Dec 16, 2024
fdd351a
Merge remote-tracking branch 'origin/master' into matthias/remove-sta…
matthiasgoergens Dec 18, 2024
d642e0b
Doc
matthiasgoergens Dec 18, 2024
4643bf8
Merge remote-tracking branch 'origin/master' into matthias/remove-sta…
matthiasgoergens Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ceno_rt/ceno_link.x
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@

/* The address of this variable is the start of the stack (growing downwards). */
_stack_start = ORIGIN(REGION_STACK) + LENGTH(REGION_STACK);
_hints_start = ORIGIN(REGION_HINTS);
_hints_length = LENGTH(REGION_HINTS);
Expand Down
6 changes: 1 addition & 5 deletions ceno_rt/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ pub fn halt(exit_code: u32) -> ! {
);
}

// Look in the linker scripts `ceno_link.x` and `memory.x` for symbols like `_stack_start`.
#[cfg(target_arch = "riscv32")]
global_asm!(
"
Expand Down Expand Up @@ -98,8 +99,3 @@ _start:
ecall
",
);

extern "C" {
// The address of this variable is the start of the stack (growing downwards).
static _stack_start: u8;
}