Standalone MULTI_OBSERVE Chip
#5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darth-cy
force-pushed
the
feat/native_multi_observe
branch
from
1890560 to
3230ce8
Compare
darth-cy
force-pushed
the
feat/native_multi_observe
branch
from
3230ce8 to
831470c
Compare
|
I think it's more reasonable to reuse
|
kunxian-xia
reviewed
Aug 5, 2025
Comment on lines
+262
to
+266
| builder | ||
| .when(is_observe) | ||
| .when(next.enable) | ||
| .when(not(next.is_first)) | ||
| .assert_eq(next.is_observe, AB::F::ONE); |
There was a problem hiding this comment.
We have to reduce this constraint's degree to 3 so as to set log_blowup = 1.
Comment on lines
+309
to
+313
| builder | ||
| .when(is_observe) | ||
| .when(not(is_final)) | ||
| .when(not(should_permute)) | ||
| .assert_eq(next.curr_timestamp - curr_timestamp, AB::F::TWO); |
There was a problem hiding this comment.
Let's try to reduce this constraint's degree to 3.
Comment on lines
+315
to
+318
| .when(is_observe) | ||
| .when(not(is_final)) | ||
| .when(should_permute) | ||
| .assert_eq(next.curr_timestamp - curr_timestamp, AB::F::from_canonical_usize(4)); |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new specialized chip extension to handle multiple observation into the transcript in one instruction
MULTI_OBSERVE.