Skip to content

[Refacto] Separate circuits/types into multiple crates #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

noel2004
Copy link
Member

In a "end game" purpose for zkvm-prover, we moved out the circuits crates into scroll mono repo and left zkvm prover a "universal" one without explicit knowledge to every circuit. While in scroll monorepo, the crates of circuits need to share parts of codes with coordinator via libzkp.

To achieve such a designation in the future, this PR made some refactoring to the all-in-one circuit-types crate and separate it into several parts:

  1. the base crate being shared between libzkp and crates of circuits, so libzkp (and all go modules loading it) do not need to depend on the openvm related crates
  2. separated crates for different circuits, they are also shared between libzkp and the corresponding circuit, it make the circuit has less dependencies (for example, batch and bundle do not need sbv)
  3. the circuit crate being shared between crates of circuits, including dependencies of openvm

@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-prover Updates to the prover crate crate-verifier Updates to the verifier crate crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels May 28, 2025
@github-actions github-actions bot added the crate-integration Updates to the integration crate label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate crate-prover Updates to the prover crate crate-verifier Updates to the verifier crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants