Skip to content

Refactor test utils to use a class #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 25, 2025
Merged

Refactor test utils to use a class #30

merged 23 commits into from
Feb 25, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Feb 21, 2025

This brings the test utils into good shape

@flying-sheep flying-sheep changed the title Less stringly typed Refactor test utils to use a class Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.53%. Comparing base (042b108) to head (fb5d1fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fast_array_utils/conv/_asarray.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   95.45%   95.53%   +0.08%     
==========================================
  Files           9        9              
  Lines         110      112       +2     
==========================================
+ Hits          105      107       +2     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #30 will create unknown performance changes

Comparing pa/test-type (fb5d1fa) with main (042b108)

Summary

🆕 46 new benchmarks
⁉️ 38 (👁 38) dropped benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_to_dense_benchmark[csc-float32-C] 4.2 ms N/A N/A
👁 test_to_dense_benchmark[csc-float32-F] 4.2 ms N/A N/A
👁 test_to_dense_benchmark[csc-float64-C] 8.3 ms N/A N/A
👁 test_to_dense_benchmark[csc-float64-F] 8.3 ms N/A N/A
👁 test_to_dense_benchmark[csr-float32-C] 4.2 ms N/A N/A
👁 test_to_dense_benchmark[csr-float32-F] 4.2 ms N/A N/A
👁 test_to_dense_benchmark[csr-float64-C] 8.3 ms N/A N/A
👁 test_to_dense_benchmark[csr-float64-F] 8.3 ms N/A N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csc_array-C] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csc_array-F] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csc_matrix-C] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csc_matrix-F] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csr_array-C] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csr_array-F] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csr_matrix-C] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float32-scipy.sparse.csr_matrix-F] N/A 4.2 ms N/A
🆕 test_to_dense_benchmark[float64-scipy.sparse.csc_array-C] N/A 8.3 ms N/A
🆕 test_to_dense_benchmark[float64-scipy.sparse.csc_array-F] N/A 8.3 ms N/A
🆕 test_to_dense_benchmark[float64-scipy.sparse.csc_matrix-C] N/A 8.3 ms N/A
🆕 test_to_dense_benchmark[float64-scipy.sparse.csc_matrix-F] N/A 8.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More questions than comments at this point, code looks generally good

@flying-sheep flying-sheep merged commit efa2986 into main Feb 25, 2025
11 of 12 checks passed
@flying-sheep flying-sheep deleted the pa/test-type branch February 25, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants