-
Notifications
You must be signed in to change notification settings - Fork 96
sq.pp.filter_cells
for SpatialData
#1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
selmanozleyen
wants to merge
11
commits into
scverse:main
Choose a base branch
from
selmanozleyen:feature/filter_cells_new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
sq.pp.filter_cells
for SpatialData
#1011
selmanozleyen
wants to merge
11
commits into
scverse:main
from
selmanozleyen:feature/filter_cells_new
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 66.63% 66.80% +0.16%
==========================================
Files 40 41 +1
Lines 6060 6160 +100
Branches 1015 1036 +21
==========================================
+ Hits 4038 4115 +77
- Misses 1662 1673 +11
- Partials 360 372 +12
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007.
Hi @timtreis ,
I changed some things compared to your PR: #967 . The things I changed:
min_counts, min_genes, max_counts, max_genes
since all of them can be handled by the call ofsc.filter_cells
The code from what I understand should be in the following logic.
sc.filter_cells
filter the tables and update others based on that. If there is no actual filtering I think it would be best because we would assure same behavior withsc.filter_cells
What needs to be done:
Tests fails because scverse/spatialdata#946 needs to be merged first