-
Notifications
You must be signed in to change notification settings - Fork 49
Update Scylla version in CI #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -42,7 +42,8 @@ | |||||||
greaterthancass21, assert_startswith, greaterthanorequalcass40, | ||||||||
lessthancass40, | ||||||||
TestCluster, requires_java_udf, requires_composite_type, | ||||||||
requires_collection_indexes, SCYLLA_VERSION, xfail_scylla, xfail_scylla_version_lt) | ||||||||
requires_collection_indexes, SCYLLA_VERSION, xfail_scylla, xfail_scylla_version_lt, | ||||||||
requirescompactstorage) | ||||||||
|
||||||||
from tests.util import wait_until | ||||||||
|
||||||||
|
@@ -428,6 +429,7 @@ def test_composite_in_compound_primary_key_ordering(self): | |||||||
self.check_create_statement(tablemeta, create_statement) | ||||||||
|
||||||||
@lessthancass40 | ||||||||
@requirescompactstorage | ||||||||
def test_compact_storage(self): | ||||||||
create_statement = self.make_create_statement(["a"], [], ["b"]) | ||||||||
create_statement += " WITH COMPACT STORAGE" | ||||||||
|
@@ -437,6 +439,7 @@ def test_compact_storage(self): | |||||||
self.check_create_statement(tablemeta, create_statement) | ||||||||
|
||||||||
@lessthancass40 | ||||||||
@requirescompactstorage | ||||||||
def test_dense_compact_storage(self): | ||||||||
create_statement = self.make_create_statement(["a"], ["b"], ["c"]) | ||||||||
create_statement += " WITH COMPACT STORAGE" | ||||||||
|
@@ -456,6 +459,7 @@ def test_counter(self): | |||||||
self.check_create_statement(tablemeta, create_statement) | ||||||||
|
||||||||
@lessthancass40 | ||||||||
@requirescompactstorage | ||||||||
def test_counter_with_compact_storage(self): | ||||||||
""" PYTHON-1100 """ | ||||||||
create_statement = ( | ||||||||
|
@@ -468,6 +472,7 @@ def test_counter_with_compact_storage(self): | |||||||
self.check_create_statement(tablemeta, create_statement) | ||||||||
|
||||||||
@lessthancass40 | ||||||||
@requirescompactstorage | ||||||||
def test_counter_with_dense_compact_storage(self): | ||||||||
create_statement = ( | ||||||||
"CREATE TABLE {keyspace}.{table} (" | ||||||||
|
@@ -2126,7 +2131,8 @@ def setUp(self): | |||||||
self.session.execute("CREATE TABLE {0}.{1} (pk int PRIMARY KEY, c int)".format(self.keyspace_name, self.function_table_name)) | ||||||||
self.session.execute( | ||||||||
"CREATE MATERIALIZED VIEW {0}.mv1 AS SELECT pk, c FROM {0}.{1} " | ||||||||
"WHERE pk IS NOT NULL AND c IS NOT NULL PRIMARY KEY (pk, c)".format( | ||||||||
"WHERE pk IS NOT NULL AND c IS NOT NULL PRIMARY KEY (pk, c) " | ||||||||
"WITH compaction = {{ 'class' : 'SizeTieredCompactionStrategy' }}".format( | ||||||||
self.keyspace_name, self.function_table_name) | ||||||||
Comment on lines
+2135
to
2136
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The string formatting is incorrect. The
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And again the bot is dumb. Double braces are a mean to escape the braces so they are put literally. There are 2 format args, and 2 placeholders - 0 and 1. I don't see a bug here. |
||||||||
) | ||||||||
|
||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
InvalidRequest
exception class is used but not imported. This will cause a NameError at runtime when the decorator is applied.Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bot is dump, this exception is definitely imported: