Skip to content

Conversation

adi-QTPi
Copy link

Adds a new route /admin/nodes/up which starts all the app containers supposed to be on the given worker node running AppMaker.

  • Restarts stopped containers.
  • Creates the app, if container does not exist.

Request body

{
    "node_ip": "100.114.106.39:4000"
}

@adi-QTPi adi-QTPi requested a review from kunalvirwal October 11, 2025 11:20
Copy link
Collaborator

@kunalvirwal kunalvirwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many changes required. Take the final changes from Up Node, Down Node and Shift Node branches and raise a new PR for Up Node

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send this file back to /lib/factory/protos/application/application.proto

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ContainerRquestBody is redundant. Use NameHolder instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name of ContainerResponseBody.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerate protobuff files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document these routes in /docs/content/api/specs/openapi.json with proper API inputs and outputs, and test if docs are running properly on local.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the downNode route

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name of UpNodeRequest to UpNodePayload

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the Response struct. Not needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove fmt package. Use the logger package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check for whether the provided IP is:

  1. A valid IP address.
  2. A valid appmaker node.
  3. A valid appmaker port.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add custom error replies for invalid port or appmaker IP:port using errors.new().

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix inconsistent error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants