Skip to content

Add WaitingPlugin support #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

Add WaitingPlugin support #395

merged 2 commits into from
Jul 13, 2025

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Jul 13, 2025

  • Added ability for plugins to inform the system they need to pause event processing.
  • Added WaitingPlugin conformance and auto-pause during add(plugin).
  • Added analytics.pauseEventProcessing.
  • Added analytics.resumeEventProcessing.
  • Fixed issue where update(initial) would be called twice on destination plugins.
  • Added tests.

Copy link

codecov bot commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 94.57364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.80%. Comparing base (e83f63e) to head (024c239).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Segment/Waiting.swift 89.58% 5 Missing ⚠️
Sources/Segment/Settings.swift 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   70.25%   70.80%   +0.54%     
==========================================
  Files          48       49       +1     
  Lines        4794     4898     +104     
==========================================
+ Hits         3368     3468     +100     
- Misses       1426     1430       +4     
Files with missing lines Coverage Δ
Sources/Segment/Analytics.swift 84.56% <100.00%> (+0.04%) ⬆️
Sources/Segment/Plugins.swift 96.15% <100.00%> (+0.32%) ⬆️
Sources/Segment/State.swift 97.40% <100.00%> (+1.52%) ⬆️
Sources/Segment/Settings.swift 59.12% <77.77%> (+1.19%) ⬆️
Sources/Segment/Waiting.swift 89.58% <89.58%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsneed bsneed merged commit ddbbec2 into main Jul 13, 2025
11 checks passed
@bsneed bsneed deleted the bsneed/waiting branch July 13, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants