-
Notifications
You must be signed in to change notification settings - Fork 717
Fix wrong offset calculation in SOME/IP-TP #1898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1898 +/- ##
========================================
Coverage 82.88% 82.89%
========================================
Files 292 292
Lines 51830 51833 +3
Branches 11501 11234 -267
========================================
+ Hits 42960 42965 +5
+ Misses 7706 7650 -56
- Partials 1164 1218 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @seladb,
sorry, I am in vacations and missed your first message. Thank you very much for the fix, it looks correct. I like that you added a check in the setter!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fixes #1890