Skip to content

Fix wrong offset calculation in SOME/IP-TP #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

Conversation

seladb
Copy link
Owner

@seladb seladb commented Jul 26, 2025

Fixes #1890

Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.89%. Comparing base (440f19b) to head (a70b2f7).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #1898    +/-   ##
========================================
  Coverage   82.88%   82.89%            
========================================
  Files         292      292            
  Lines       51830    51833     +3     
  Branches    11501    11234   -267     
========================================
+ Hits        42960    42965     +5     
+ Misses       7706     7650    -56     
- Partials     1164     1218    +54     
Flag Coverage Δ
alpine320 74.70% <100.00%> (+<0.01%) ⬆️
fedora42 74.83% <100.00%> (+0.02%) ⬆️
macos-13 81.10% <100.00%> (+<0.01%) ⬆️
macos-14 81.10% <100.00%> (+<0.01%) ⬆️
macos-15 81.10% <100.00%> (+<0.01%) ⬆️
mingw32 70.17% <100.00%> (+0.02%) ⬆️
mingw64 70.17% <100.00%> (+<0.01%) ⬆️
rhel94 74.57% <100.00%> (+0.02%) ⬆️
ubuntu2004 58.87% <83.33%> (+0.02%) ⬆️
ubuntu2004-zstd 58.98% <83.33%> (+<0.01%) ⬆️
ubuntu2204 74.48% <100.00%> (-0.02%) ⬇️
ubuntu2204-icpx 60.87% <80.00%> (+<0.01%) ⬆️
ubuntu2404 74.73% <100.00%> (+<0.01%) ⬆️
ubuntu2404-arm64 74.71% <100.00%> (+<0.01%) ⬆️
unittest 82.89% <100.00%> (+<0.01%) ⬆️
windows-2022 85.03% <100.00%> (+<0.01%) ⬆️
windows-2025 85.06% <100.00%> (+<0.01%) ⬆️
winpcap 85.06% <100.00%> (+<0.01%) ⬆️
xdp 51.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@simon-germany simon-germany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @seladb,

sorry, I am in vacations and missed your first message. Thank you very much for the fix, it looks correct. I like that you added a check in the setter!

@seladb seladb marked this pull request as ready for review July 31, 2025 08:36
Copy link
Collaborator

@Dimi1010 Dimi1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tigercosmos tigercosmos merged commit 5b437d3 into dev Jul 31, 2025
42 checks passed
@tigercosmos tigercosmos deleted the bugfix-some-ip-tp branch July 31, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants