This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Com content draconian start #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggest article elements be moved into the item file with the rest of the article rows and columns are presentational, they don't belong in the HTML
|
Wow! I can't believe I missed Paladin's contributions. Geez, sorry :( I am in full support of (re)moving presentational +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start by thinking the relatively unthinkable. This pull suggests:
moving the article element into the item file, where it sits with the rest of the article content.
Getting rid of the row/column counting, because they presentational considerations, and doesn't belong in the HTML file.
In short, I've removed everything that I could that is presentational.
Also switched the list of links to a nag, which to me seems the right choice.
I stopped sort of wrapping the initial page-header in a header element, because it doesn't look to me anything else shows up there.