Skip to content

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Aug 19, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7469](https://sendbird.atlassian.net/browse/CLNP-7469)

Description Of Changes

Android API 35 에서 강화된 edge-to-edge 적용 으로 인해 keyboard 가 ChannelInput을 가리는 문제입니다.
기존 코드는 유지하고 35 이상에서만 예외처리 추가하였습니다.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee requested a review from Copilot August 19, 2025 23:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.26%. Comparing base (9cf3c39) to head (4e640f0).

Files with missing lines Patch % Lines
...react-native/src/components/ChannelInput/index.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   11.27%   11.26%   -0.01%     
==========================================
  Files         360      360              
  Lines        8676     8680       +4     
  Branches     2328     2450     +122     
==========================================
  Hits          978      978              
- Misses       7697     7701       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee changed the title fix: improve keyboard avoidance behavior for Android API 35+ [CLNP-7469] fix: improve keyboard avoidance behavior for Android API 35+ Aug 19, 2025
@OnestarLee OnestarLee requested a review from bang9 August 19, 2025 23:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes keyboard avoidance behavior for Android API 35+ devices where enhanced edge-to-edge enforcement causes the keyboard to obscure the ChannelInput component. The solution adds platform-specific handling while maintaining backward compatibility with older Android versions.

  • Adds Android API 35+ detection logic for keyboard avoidance
  • Updates keyboard behavior configuration to use padding on Android API 35+
  • Conditionally removes SafeAreaBottom component for Android API 35+

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OnestarLee OnestarLee added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit a7618af Aug 21, 2025
7 checks passed
@OnestarLee OnestarLee deleted the fix/support-android-15-keyboard-avoid branch August 21, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants