Skip to content

fix: Correct some minor typos #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Correct some minor typos #503

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf419cf
orignal ==> original
fkmy Oct 24, 2024
45f9643
receiveing ==> receiving
fkmy Oct 24, 2024
ca5c3a5
successfuly ==> successfully
fkmy Oct 24, 2024
a7cd448
verison ==> version
fkmy Oct 24, 2024
e5257a9
sengrid ==> sendgrid
fkmy Oct 24, 2024
a7807bb
sengrid-ruby ==> sendgrid-ruby
fkmy Oct 24, 2024
264c7e1
Fix: Capitalize "Inbound" for consistency with SendGrid terminology
fkmy Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/helpers/eventwebhook/example.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'sengrid-ruby'
require 'sendgrid-ruby'
include SendGrid

def is_valid_signature(request)
Expand Down
2 changes: 1 addition & 1 deletion examples/mail/mail.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"enable": true,
"html": "If you would like to unsubscribe and stop receiving these emails <% clickhere %>.",
"substitution_tag": "<%click here%>",
"text": "If you would like to unsubscribe and stop receiveing these emails <% click here %>."
"text": "If you would like to unsubscribe and stop receiving these emails <% click here %>."
}
}
}')
Expand Down
2 changes: 1 addition & 1 deletion lib/sendgrid/helpers/inbound/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
require 'sinatra'
rescue LoadError
puts <<-NOTE
As of sengrid verison 6, sinatra is no longer specified as a dependency of
As of sendgrid version 6, sinatra is no longer specified as a dependency of
Copy link

@RileyManda RileyManda Sep 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, use Inbound as used in other sections(Example,in this file::lib/sendgrid/helpers/inbound/public/index.html,inbound is written as Inbound) unless inbound and Inbound refer to two different things.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'll update line 6 from "inbound server" to "Inbound server" to maintain consistency with other references like "Inbound Parse webhook" and "Inbound Parse data" used elsewhere in the codebase.

the sendgrid gem. All the functionality of the inbound server is still the same
and fully supported, but you just need to include the sinatra dependency in your gemfile
yourself, like so:
Expand Down
2 changes: 1 addition & 1 deletion lib/sendgrid/helpers/inbound/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<title>Twilio SendGrid Incoming Parse</title>
</head>
<body>
<h1>You have successfuly launched the server!</h1>
<h1>You have successfully launched the server!</h1>

Check out <a href="https://github.com/sendgrid/sendgrid-ruby/tree/HEAD/sendgrid/helpers/inbound">the documentation</a> on how to use this software to utilize the SendGrid Inbound Parse webhook.
</body>
Expand Down
2 changes: 1 addition & 1 deletion spec/rack/sendgrid_webhook_verification_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

let(:middleware) { Rack::SendGridWebhookVerification.new(@spy_app, public_key, %r{/email}) }

it 'keeps orignal reading position' do
it 'keeps original reading position' do
options = {
:input => Fixtures::EventWebhook::PAYLOAD,
'Content-Type' => "application/json"
Expand Down
2 changes: 1 addition & 1 deletion test/sendgrid/test_sendgrid-ruby.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,7 @@ def test_mail_send_post
"enable": true,
"html": "If you would like to unsubscribe and stop receiving these emails <% clickhere %>.",
"substitution_tag": "<%click here%>",
"text": "If you would like to unsubscribe and stop receiveing these emails <% click here %>."
"text": "If you would like to unsubscribe and stop receiving these emails <% click here %>."
}
}
}')
Expand Down
Loading