-
Notifications
You must be signed in to change notification settings - Fork 165
Adding MCP call (via HTTP) #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amin-nikanjam
wants to merge
11
commits into
serverlessworkflow:main
Choose a base branch
from
amin-nikanjam:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−3
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
52bfdce
Adding MCP call and two examples
amin-nikanjam 63f0780
Update dsl-reference.md
amin-nikanjam b5c40ab
Apply minor fixes
amin-nikanjam b06b731
Adding MCP calls
amin-nikanjam fe0edc6
Adding MCP call specification
amin-nikanjam e576d87
Adding a note to clarify on HTTP vs STDIO
amin-nikanjam 9512fa6
Update dsl-reference.md
amin-nikanjam 99af703
Update dsl-reference.md
amin-nikanjam cee02aa
Update dsl-reference.md
amin-nikanjam 068b8e1
Update dsl-reference.md
amin-nikanjam fbade4a
Minor fixes
amin-nikanjam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
protocolVersion
a required parameter if I useinitialize
? If so, can we rephrase?Also, if the user does not provide it, I understand from your writing that the runtime will append this parameter. It comes from where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the initialization phase MUST be the first interaction between MCP client and server, and include 'protocolVersion'. The client sends its supported version in the initialize request, and if the server supports it, it responds with the same version. It should be mentioned in the MCP client's specification. I assume if the runtime supports MCP, it should have the supported version. Do you suggest changing any part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should enforce a minimum protocol version that runtimes MUST implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to support the latest version (i.e., 2025-06-18) or the one before that (2025-03-26).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the latest version.