Skip to content

feat: unit tests for the data.ts class #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

feat: unit tests for the data.ts class #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9af620b
chore: add more unit tests for data.ts
javabudd Aug 9, 2025
cf26f66
chore: add unit tests for generateAttachmentKeyIfEmpty, add more asse…
javabudd Aug 9, 2025
a39720a
fix: updateGuardNodes assertion
javabudd Aug 9, 2025
6e1762d
chore: add unit tests for updateSwarmNodesForPubkey, clearOutAllSnode…
javabudd Aug 9, 2025
2dfaf6b
chore: testing fetchConvoMemoryDetails, getConversationById, removeCo…
javabudd Aug 9, 2025
061a36c
chore: testing getPubkeysInPublicConversation, searchConversations, s…
javabudd Aug 9, 2025
41b91e0
chore: testing searchMessagesInConversation, cleanSeenMessages, clean…
javabudd Aug 9, 2025
8604fde
chore: testing simple channel tests, formatting updates
javabudd Aug 9, 2025
82fff2f
chore: add several more unit tests
javabudd Aug 9, 2025
f49706f
chore: fix test stubs
javabudd Aug 9, 2025
65c497f
chore: add channel mocking to its own method
javabudd Aug 9, 2025
7b07612
chore: add several more unit tests
javabudd Aug 9, 2025
bc13a4b
fix: improperly typed skipTimerInit variable
javabudd Aug 9, 2025
058d45c
chore: add several more unit tests
javabudd Aug 9, 2025
c6870a1
chore: add unit tests for getLastMessagesByConversation
javabudd Aug 10, 2025
346c285
chore: add more unit tests for data class
javabudd Aug 10, 2025
15a839a
chore: add more tests and remove usages of any
javabudd Aug 10, 2025
0979d61
chore: add test for getLastMessagesByConversation
javabudd Aug 10, 2025
f15beff
fix: formatting for getLastMessagesByConversation
javabudd Aug 10, 2025
4a44ff9
chore: adding more unit tests
javabudd Aug 10, 2025
d04b806
chore: add several more unit tests
javabudd Aug 10, 2025
2da9a48
chore: adding more unit tests
javabudd Aug 10, 2025
3dd4c2a
chore: add getAllConversations test for invalid data
javabudd Aug 10, 2025
c89fd46
chore: merge dev
javabudd Aug 26, 2025
eb3f0fb
chore: clean up unit test placement
javabudd Aug 26, 2025
d867b2b
fix: restore changes
javabudd Aug 26, 2025
f99cb9b
Merge branch 'dev' of https://github.com/session-foundation/session-d…
javabudd Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ts/data/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ async function getMessagesByConversation(
skipTimerInit = false,
returnQuotes = false,
messageId = null,
}: { skipTimerInit?: false; returnQuotes?: boolean; messageId: string | null }
}: { skipTimerInit?: boolean; returnQuotes?: boolean; messageId: string | null }
): Promise<{ messages: Array<MessageModel>; quotes: Array<Quote> }> {
const { messages, quotes } = await channels.getMessagesByConversation(conversationId, {
messageId,
Expand Down
Loading