Skip to content

Update bindgen; Update MSRV to 1.70 #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 18, 2025
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 5, 2025

Context

Description

This PR bumps the MSRV to 1.70 and updates the bindgen dependency to 0.72.0 (the latest current release).

Details:

  • Updated bindgen-related logic to be compatible the 0.72.0 API changes.
  • Applied a "cargo clippy --fix", and removed a clippy-allow that's no longer needed.

@alex
Copy link
Collaborator

alex commented Aug 5, 2025

Is there a reason you changed all the dependencies to use a workspace crate? It seems orthagonal to the purpose of this PR

@justsmth
Copy link
Contributor Author

justsmth commented Aug 5, 2025

Yeah, you're right. That's a completely optional part of this change. I can revert it if you prefer.

@alex
Copy link
Collaborator

alex commented Aug 5, 2025 via email

@justsmth
Copy link
Contributor Author

justsmth commented Aug 6, 2025

I reverted my changes related to dependency configuration. I could (did) also revert the bindgen "RustTarget" back to v1.47.0 if you'd prefer. (Sorry, I took more liberties than I should've in a single PR.)

-- EDIT: I changed the bindgen Rust target back to 1.47 to be safe.

@justsmth
Copy link
Contributor Author

Is anything else needed for this PR? (I think the CI failure is unrelated?)

@alex alex merged commit f93e8c9 into sfackler:master Aug 18, 2025
86 checks passed
@alex
Copy link
Collaborator

alex commented Aug 18, 2025

thanks for following up here!

@justsmth justsmth deleted the bindgen-0.72 branch August 18, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants