-
Notifications
You must be signed in to change notification settings - Fork 15
SHARD-2660: save certificates in cycles table #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
…n checkpointing hash calc.
do security review |
🔍 Security Review ReportClick to expand security review details
Generated by argus-agent security review |
do security review |
🔍 Security Review ReportClick to expand security review details
Generated by argus-agent security review |
PR Type
Enhancement, Tests
Description
Add support for storing certificates in cycles table
Update database schema and logic for certificates field
Refactor validation to handle certificates correctly
Add and extend unit tests for certificates handling
Changes walkthrough 📝
6 files
Store certificates in cycle data records
Refactor validation to ignore certificates field
Preserve certificates during cycle data collection
Add certificates column to cycles insert/update logic
Add certificates column to cycles table schema
Update Cycle and DbCycle types to include certificates
6 files
Add tests for storing cycles with/without certificates
Add and extend tests for cycle validation with certificates
Add tests for inserting cycles with/without certificates
Update test for cycles table schema change
Update mock data to use certificates array
Update mock cycle data to use certificates array