Skip to content

Conversation

mssabr01
Copy link

@mssabr01 mssabr01 commented Sep 5, 2025

User description

…nused dependency on lib-types


PR Type

enhancement, dependencies


Description

  • Upgraded typescript devDependency from 4.5.5 to 4.9.5

  • Removed unused @shardeum-foundation/lib-types dependency

  • Cleaned up dependency list for improved compatibility


Changes walkthrough 📝

Relevant files
Dependencies
package.json
Remove unused dependency and upgrade TypeScript version   

package.json

  • Removed @shardeum-foundation/lib-types from dependencies
  • Upgraded typescript from 4.5.5 to 4.9.5 in devDependencies
  • Improved dependency hygiene and compatibility
  • +1/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @mssabr01
    Copy link
    Author

    mssabr01 commented Sep 5, 2025

    tests pass

    Copy link

    github-actions bot commented Sep 5, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🏅 Score: 95
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Removal

    Confirm that removing the @shardeum-foundation/lib-types dependency does not break any imports or type usages elsewhere in the codebase.

    "dependencies": {
      "buffer-xor": "2.0.2",
      "fast-stable-stringify": "1.0.0",
      "sodium-native": "4.3.1"
    },
    Typescript Version Upgrade

    Ensure that upgrading typescript from 4.5.5 to 4.9.5 does not introduce compatibility issues or require code changes elsewhere in the project.

    "typescript": "4.9.5"

    Copy link

    github-actions bot commented Sep 5, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @mssabr01 mssabr01 changed the title updated typescript to resolve compait issue when compiling, removed u… SHARD-2643 updated typescript to resolve compait issue when compiling, removed u… Sep 5, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant