-
Notifications
You must be signed in to change notification settings - Fork 124
Add volume for trivy #1955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume for trivy #1955
Conversation
b36c79d
to
0f8af77
Compare
/release-note |
@hasanawad94: the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0f8af77
to
c9c7e04
Compare
c9c7e04
to
a041dea
Compare
a041dea
to
4beb8cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possible improvement otherwise it lgtm.
4beb8cf
to
8267c92
Compare
Documenting the "bigger picture" request here: #1969 |
@rxinui , @adambkaplan looks OK and safe to merge ? |
/lgtm |
Added env variables for trivy to configure writing to volumes instead of the root filesystem. Added a utility function `AppendWriteableVolumes` to be used for appending volumes to steps. Volumes introduced to trivy: - volume for trivy cache - volume for tmp data Set env variables: - TRIVY_CACHE_DIR - TMPDIR Signed-off-by: Hasan Awad <[email protected]>
8267c92
to
201b75a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Breaking the changes of #1885 into smaller prs to make review easier in the effort of better security practices for the containers that are used for the build process.
Changes
Added env variables for trivy to configure writing to volumes instead of the root filesystem.
Added a utility function
AppendWriteableVolumes
to be used for appending volumes to steps.Volumes introduced to trivy:
Set env variables:
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes