chore: Refactor GenerateTaskRun with improved modularity and naming consistency

[ayushsatyam146]

Changes

The existing TaskRun generation logic was concentrated in a single monolithic
GenerateTaskRun function, making it difficult to maintain, test, and debug
individual configuration aspects. This created tight coupling and poor separation
of concerns.

Decomposed the monolithic GenerateTaskRun into a comprehensive function.
orchestrated by smaller, single-responsibility helper functions. Each
configuration aspect now has its own dedicated applyXFeature* function.
This approach enables better error isolation, easier unit testing of individual
components, and clearer code organization. Enhanced error messages now provide
specific context about which BuildRun and strategy caused failures, improving
debugging experience for operators.

Key architectural changes:

• Made GenerateTaskRun as the main entry point and removed the GenerateTaskSpec
• Extracted applyNodeSelectors, applyTolerations, applyScheduler functions
• Renamed addBuildStrategySteps → applyBuildStrategySteps for consistency
• Renamed addStrategyParametersToTaskSpec → applyStrategyParametersToTaskSpec
• Introduced initializeTaskRun, buildTaskSpec, and createBaseTaskSpec helpers
• Improved error messages with BuildRun and strategy context

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

[ayushsatyam146]

/retest

[hasanawad94]

/lgtm

[adambkaplan]

@ayushsatyam146 PR needs rebase, looks like there is a merge conflict with one of the test files.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[ayushsatyam146]

Hi @adambkaplan I resolved the merge conflict here, PTAL thanks!

[adambkaplan]

First off, I want to commend you @ayushsatyam146 for this submisssion. The refactored form of taskrun.go is much clearer to read and will make it easier to add future contributions. I especially like that the features which apply to the TaskRun as a whole (node selector, annotations, etc.) are separated from features that apply to specific build steps (obtaining source code, processing the output image, etc.).

The refactor in taskrun_test.go likewise adds coverage that was missing and/or makes it clearer which behaviors are being verified at the "unit" level. In particular, the following test cases are improved:

• Handling of parameter types + defaults
• Handling of volumes (definition, overrides)
• Checks that verify the image processing step is included

That said, it appears there are a few checks in the original code that are missing. Given that we want to release v0.17.0 soon, this PR as is presents a risk due to removed test coverage. Based on my analysis (with the help of Cursor), a few checks were removed:

• Verify the arguments passed to the image-processing step
• Verify the existence of the source clone step and its arguments
• Verify the compute resources are correctly specified in the TaskRun

I tried to identify these specific missing tests/checks in my comments.

[adambkaplan]

/approve

Green-lighting this as a "feature" to be added.

/hold

The size of change, and impact on test coverage, presents a risk to the release. My vote is to hold this PR until after the release, at which point we can merge it early in the v0.18.0 lifecycle.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adambkaplan]

/hold cancel

v0.17.0 is released!