Allow for choice of shell #31
Open
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change gives users the option to set the shell under which the `docker cp` command will run. It uses `/bin/bash` by default, so the change should be backwards compatible.
|
@jverce thank you very much for the contribution! I think this is a great improvement :) I'll release this as |
shrink
requested changes
Jul 10, 2025
src/extract.js
Outdated
| @@ -6,6 +6,9 @@ async function run() { | |||
| const image = core.getInput('image'); | |||
| const path = core.getInput('path'); | |||
| const destination = core.getInput('destination') || `extracted-${Date.now()}`; | |||
| const shell = core.getInput('shell', { | |||
| default: '/bin/bash', | |||
There was a problem hiding this comment.
@jverce I don't recall default being an option for getInput, I think the runner automatically injects the default value so that getInput('shell') will be populated with the default when no value is specified. Does this add (new?) functionality or can we remove it and rely on the normal runner behaviour?
There was a problem hiding this comment.
TBH, Copilot suggested it. I guess Copilot doesn't know its own libs 😂
I just removed it based on your feedback. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change gives users the option to set the shell under which the
docker cpcommand will run. It uses/bin/bashby default, so the change should be backwards compatible.Solves #30