feat: implement zswap support #11199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/zswap
branch
3 times, most recently
from
20b7155 to
b0a4ec5
Compare
Zswap allows to compress pages in memory before they hit the actual swap device. Both swap and zswap (or either one of these) can be enabled. Fixes siderolabs#10675 Signed-off-by: Andrey Smirnov <[email protected]>
smira
commented
Jun 14, 2025
| 172.20.0.5 runtime ZswapStatus zswap 1 0 B 0 0 0 | ||
| ``` | ||
|
|
||
| Removing a `ZswapConfig` document will disable zswap on the system. |
There was a problem hiding this comment.
TODO: add a note about Kubernetes & swap, talosctl cgroups --preset swap
frezbo
reviewed
Jun 25, 2025
| } | ||
| } | ||
|
|
||
| if err = safe.CleanupOutputs[*runtime.KernelParamSpec](ctx, r); err != nil { |
There was a problem hiding this comment.
is cleaning up enough, or do we need to explicitly set sys.module.zswap.parameters.enabled to N?
There was a problem hiding this comment.
yes, cleaning up is enough - the kernel param controller reverts the value to the previous setting ('N') if the spec is removed
frezbo
reviewed
Jun 25, 2025
| ``` | ||
|
|
||
| Removing a `SwapVolumeConfig` document will remove the swap device from the system, but the partition will remain on the disk. | ||
| To |
There was a problem hiding this comment.
I guess the To is to add docs about removing the partition?
frezbo
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zswap allows to compress pages in memory before they hit the actual swap device.
Both swap and zswap (or either one of these) can be enabled.
Fixes #10675