feat: enforce Kubernetes version compatibility #11208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/k8s-version-compat
branch
from
1153e7b to
13f9d76
Compare
|
I removed the upgrade pre-checks for Kubernetes version, as now they are handled by the config validation anyways - config validation with new |
utkuozdemir
reviewed
Jun 13, 2025
smira
force-pushed
the
feat/k8s-version-compat
branch
2 times, most recently
from
6db6614 to
8ed5e1f
Compare
smira
force-pushed
the
feat/k8s-version-compat
branch
from
8ed5e1f to
cd83074
Compare
utkuozdemir
approved these changes
Jun 27, 2025
frezbo
reviewed
Jun 27, 2025
|
|
||
| expectedVersion string | ||
| }{ | ||
| { |
There was a problem hiding this comment.
maybe also have ones without tag and one with just sha and no tag
There was a problem hiding this comment.
we don't allow no tag, as we won't be able to guess the version this way....
There was a problem hiding this comment.
but this might be a breaking change, so I will add a note that the tag is required
frezbo
approved these changes
Jun 27, 2025
Fixes siderolabs#11198 We should enforce in following places: * before starting `upgrade-k8s`, check that all Talos machines would end up with a valid version * validate in Talos machine configuration, this will cover both upgrades, new installs, and any machine configuration manual edits Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/k8s-version-compat
branch
from
cd83074 to
4da2dd5
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11198
We should enforce in following places:
upgrade-k8s, check that all Talos machines would end up with a valid version