fallback for json.loads tool function args #1164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermokarst
force-pushed
the
thermokarst_jj_psmwmvmpnlpy
branch
from
0b07568 to
0e37f56
Compare
|
@thermokarst I ran into the same issue and created a PR for it: #1170 (didn't recognize yours as the same issue at the time). I'm not sure if it ever happens in practice, but I think you need to account for the possibility arguments split between streamed chunks. I'm happy to close mine and point to yours (since it's earlier) if you account for that possibility (or can convince me that it would never happen). |
some openai-compatible models (such as openrouter's anthropic models)
do not default to an empty json object when there are no arguments,
leading to a parsing error.
`function.arguments == '{}'`:
```bash
% llm --tool llm_version "What is the version?" --td -m openrouter/openai/gpt-4o
Tool call: llm_version({})
0.26
The version of the LLM is 0.26.
```
`function.arguments == ''`:
```bash
% llm --tool llm_version "What is the version?" --td -m openrouter/anthropic/claude-sonnet-4
I'll check the version of llm for you.Error: Expecting value: line 1 column 1 (char 0)
```
thermokarst
force-pushed
the
thermokarst_jj_psmwmvmpnlpy
branch
from
0e37f56 to
e9c573a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some openai-compatible models (such as openrouter's anthropic models) do not default to an empty json object when there are no arguments, leading to a parsing error.
function.arguments == '{}':% llm --tool llm_version "What is the version?" --td -m openrouter/openai/gpt-4o Tool call: llm_version({}) 0.26 The version of the LLM is 0.26.function.arguments == '':note - the examples above are using simonw/llm-openrouter#39