Skip to content

[HTML] Ensure safe global locale fallback setup #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: thewarwithin
Choose a base branch
from
Open

[HTML] Ensure safe global locale fallback setup #10652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00d6e4f
[HTML] Ensure safe global locale fallback setup
millanzarreta Sep 25, 2025
4bad0ae
[HTML] Ensure safe global locale fallback setup: style adjustments
millanzarreta Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions engine/report/report_html_sim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,20 +1164,37 @@ void print_profilesets( std::ostream& out, const profileset::profilesets_t& prof
out << "</div>";
}

/* Main function building the html document and calling subfunctions
*/
void print_html_( report::sc_html_stream& os, sim_t& sim )
void set_global_locale()
{
// Set global locale to en-US for consistent number formatting
try
for ( const auto& name :
{
std::locale::global( std::locale( "en_US.UTF-8" ) );
}
catch ( const std::runtime_error& )
"en_US.UTF-8",
"en_US.utf8",
"English_United States.65001",
"en_US",
"en-US",
"English_United States.1252",
"C"
} )
{
// backup spelling for CI
std::locale::global( std::locale( "en_US.utf8" ) );
try
{
std::locale::global( std::locale( name ) );
return;
}
catch ( const std::runtime_error& )
{ }
}
std::locale::global( std::locale::classic() );
}

/* Main function building the html document and calling subfunctions
*/
void print_html_( report::sc_html_stream& os, sim_t& sim )
{
// Set global locale formatting
set_global_locale();

// Set floating point formatting
os.precision( sim.report_precision );
Expand Down
Loading