Skip to content

Conversation

GiFarina
Copy link

@GiFarina GiFarina commented Aug 28, 2025

add SQL Server support.


Important

Adds Microsoft SQL Server support to PandasAI SQL extension, including documentation, code, and tests.

  • Behavior:
    • Adds support for Microsoft SQL Server in PandasAI SQL extension.
    • Updates data-ingestion.mdx and README.md to include SQL Server installation and usage instructions.
    • Adds load_from_sqlserver() function in pandasai_sql/__init__.py to handle SQL Server connections and queries.
  • Dependencies:
    • Adds pymssql as an optional dependency in pyproject.toml for SQL Server support.
  • Tests:
    • Adds test_load_from_sqlserver() and test_load_from_sqlserver_with_params() in test_sql.py to test SQL Server functionality.
  • Constants:
    • Updates SUPPORTED_SOURCE_CONNECTORS, REMOTE_SOURCE_TYPES, and SQL_SOURCE_TYPES in constants.py to include sqlserver.

This description was created by Ellipsis for c4291e8. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to c4291e8 in 1 minute and 37 seconds. Click for details.
  • Reviewed 268 lines of code in 6 files
  • Skipped 1 files when reviewing.
  • Skipped posting 7 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/v3/data-ingestion.mdx:52
  • Draft comment:
    Good update adding SQL Server support. The installation instructions and examples are clear.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. extensions/connectors/sql/README.md:3
  • Draft comment:
    README updated to include SQL Server; instructions are consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. extensions/connectors/sql/pandasai_sql/__init__.py:66
  • Draft comment:
    The new load_from_sqlserver function is consistent with other connectors. Consider rephrasing the TODO comment to 'when SQLAlchemy is used' for better grammar.
  • Reason this comment was not posted:
    Marked as duplicate.
4. extensions/connectors/sql/pyproject.toml:16
  • Draft comment:
    Dependency for pymssql and the extra for sqlserver are added correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. extensions/connectors/sql/tests/test_sql.py:240
  • Draft comment:
    Unit tests for SQL Server connector are well added. The patching of pymssql.connect and pandas.read_sql appears correct.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. pandasai/constants.py:27
  • Draft comment:
    Constants updated to include 'sqlserver' in supported connectors and SQL_SOURCE_TYPES; this keeps the definitions consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. extensions/connectors/sql/README.md:17
  • Draft comment:
    There's an extra trailing space at the end of this line. Please remove the extra whitespace.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct about the trailing space, this is an extremely minor formatting issue in a markdown file. The rules state not to make comments that are obvious or unimportant. Trailing whitespace in markdown documentation has no impact on functionality or readability. The trailing whitespace could potentially cause inconsistency in formatting across the codebase. Some development teams do care about consistent whitespace. However, this is a documentation file, not source code, and the rules specifically state not to make comments that are obvious or unimportant. This falls into that category. This comment should be removed as it points out an extremely minor formatting issue that doesn't impact functionality or readability of the documentation.

Workflow ID: wflow_8OMiYmIP6BP4Mvhs

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant